WIP: Trying to remove old connpool #8231
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
force-pushed
the
conn_pool
branch
2 times, most recently
from
4ad70a2 to
6b8c827
Compare
fantix
pushed a commit
to geldata/gel-rust
that referenced
this pull request
Aug 8, 2025
fantix
added a commit
to geldata/gel-rust
that referenced
this pull request
Aug 9, 2025
Cherry-pick from geldata/gel#8231 Co-authored-by: Matt Mastracci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #8590 landed, the new connection pool appears to be working. The new pool may have triggered the connection leak more than the old one, causing it to show up in the tests. Tests are now passing.
Pool test has been decommissioned as that requires more infrastructure work than I have time for at the moment, but we have those tests running "headlessly" in Rust code.