Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support installing musl server builds #1536

Merged
merged 4 commits into from
Mar 12, 2025
Merged

Support installing musl server builds #1536

merged 4 commits into from
Mar 12, 2025

Conversation

msullivan
Copy link
Member

We build musl servers so we might as well actually support them.
I don't know if anyone will ever use this.

Tested on an alpine linux VM.

Fixes #838.

@msullivan msullivan requested review from elprans and mmastrac March 12, 2025 01:40
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but is there a way to test this?

@msullivan
Copy link
Member Author

Yeah the right thing to do would be a test in a docker container, I guess. I instead tested manually in a VM, and as a result have already spent way longer on this issue than I should have.

@msullivan msullivan merged commit 442d9ed into master Mar 12, 2025
17 checks passed
@msullivan msullivan deleted the check-musl branch March 12, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add installation support for musl builds
2 participants