Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing 'until' condition in control plane setup #148

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

weakcamel
Copy link
Contributor

@weakcamel weakcamel commented Jun 20, 2023

This PR fixes #144
which introduced retries to network setup.

Unfortunately retries don't currently work due to missing until statement. See:
https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_loops.html#retrying-a-task-until-a-condition-is-met

You must set the until parameter if you want a task to retry. If until is not defined, the value for the retries parameter is forced to 1.

This PR also increases the number of retries from 3 to 10 12 (60 sec in total); I personally did experience situations where 15 seconds were not sufficient - and I can't think of a reason to not be a bit more permissive.

@weakcamel
Copy link
Contributor Author

CC @geerlingguy @rfranks-securenet

@geerlingguy geerlingguy merged commit 82caba3 into geerlingguy:master Jun 22, 2023
1 of 5 checks passed
@geerlingguy
Copy link
Owner

@weakcamel - Thanks! And if there's ever a truly breaking change like this, please feel free to bump with an email or tweet! There's a lot of noise out there, it's easy for something like this that actually fixes an active bug to get lost :(

@speechmatics-bot speechmatics-bot deleted the fix_networking_retries branch June 23, 2023 10:11
@weakcamel
Copy link
Contributor Author

@geerlingguy Many thanks for reviewing and accepting this PR!

With the sheer number of your repositories I can imagine how busy it gets and how spread thin you must be at times so much appreciated.

if there's ever a truly breaking change like this, please feel free to bump with an email or tweet!

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants