Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cloudfront logging #3

Merged
merged 5 commits into from
May 10, 2023
Merged

feat: Cloudfront logging #3

merged 5 commits into from
May 10, 2023

Conversation

Ic3w0lf
Copy link
Member

@Ic3w0lf Ic3w0lf commented May 10, 2023

What it solves

Add options to create an access log bucket for Cloudfront or ALB

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • Pull request title is brief and descriptive (for a changelog entry)

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, or enhancement
  • Label as bump:patch, bump:minor, or bump:major if this PR should create a new release

@github-actions
Copy link

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Cloudfront logging". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@Ic3w0lf Ic3w0lf requested a review from ckappen May 10, 2023 11:59
@Ic3w0lf Ic3w0lf changed the title Cloudfront logging feat: Cloudfront logging May 10, 2023
@Ic3w0lf Ic3w0lf merged commit 4fa16b8 into main May 10, 2023
@Ic3w0lf Ic3w0lf deleted the cloudfront-logging branch May 10, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants