fix!: Remove caching of services from container #2
+73
−100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using the container facade in the HasPolicies trait of the user-policy-bundle I noticed that the facade would return a cached instance of the
PolicyRegistry
which included a stale(?) reference to a ManagerRegistry while running our integration tests. This seems to have been caused by the cached dependencies of theFacade
class.In order to fix this there were two approaches to this:
Option 1 could have backwards compatibility breaking and implicit while Option 2 is more explicit and definitely keeps BC.
After talking and fiddling around with @janvt we came to the conclusion that it makes sense to get rid of the caching and instead only check for "swapped instances".
This change should result in a major version bump as a few methods are removed and the caching behaviour could've been interpreted as intended behaviour instead.