Enhanced few code files in the main branch. #1522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since these changes involve different modules, I invite relevant developers to serve as reviewers |
voidking
reviewed
Oct 21, 2024
| @@ -39,9 +38,6 @@ def generate_repo( | |||
| ) | |||
| from metagpt.team import Team | |||
|
|
|||
| if config.agentops_api_key != "": | |||
There was a problem hiding this comment.
Why was agentops removed?
| global _llm_stream_log | ||
| _llm_stream_log = func | ||
|
|
||
|
|
||
| def _llm_stream_log(msg): | ||
| if _print_level in ["INFO"]: |
There was a problem hiding this comment.
It looks like this changes have reverted the feature introduced in PR #1124, which allowed the define_log_level method to control stream logging via the print_level parameter. Could you please clarify the reason for this change?
better629
reviewed
Oct 21, 2024
| self._check_balance() | ||
| try: | ||
| self._check_balance() | ||
| except NoMoneyException as e: |
There was a problem hiding this comment.
already has a serialize_decorator, should we add this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key changes that i have made to the code are as follows:
This updated version includes more robust handling for running out of funds and provides better logging for project execution.
Made changes as you suggested @geekan, could you please review this PR?