Fix draw control editing bug #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://6679e16cfc92ce3aceec294d--opengeos.netlify.app |
naschmitz
reviewed
Jun 24, 2024
|
@naschmitz @sufyanAbbasi Are you Ok with merging the PR? It would be great to fix this long-standing draw control bug and include it in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the draw control bug reproted in #1899. In addtion, I improved the
redraw_layer()function by utilizing substitute layer rather than removing and adding layer. This avoids the layer flickering.Colab: https://colab.research.google.com/drive/1E9Uf4WJV060BDnH1yiwA0k5eajtLbmGj?usp=sharing
Note: The recent GDAL version fails on Windows GitHub Actions. It is irrelevant to this PR. I commented it out temporarily.