fix: empty flush tts text. #4199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheng-ri
commented
Sep 13, 2024
| @@ -31,6 +31,7 @@ class TTSReadAloudService : BaseReadAloudService(), TextToSpeech.OnInitListener | |||
| private val ttsUtteranceListener = TTSUtteranceListener() | |||
| private var speakJob: Coroutine<*>? = null | |||
| private val TAG = "TTSReadAloudService" | |||
| private var maxRetryCount = 3 | |||
There was a problem hiding this comment.
这段或许应该去掉或者加入设置，但是懒得改了
|
这样写不行，重新初始化后需要return，初始化会有回调再调用play 有更好的修复办法，你直接把那个空字符串换成第一段内容，后续添加朗读队列就跳过第一段 |
我用了一下自己分支确实遇到了这个问题，但是没找到原因。 |
sheng-ri
force-pushed
the
fix-empty-tts-text
branch
from
7e4d800
to
c28195c
Compare
sheng-ri
force-pushed
the
fix-empty-tts-text
branch
from
3b98b54
to
6f4fb34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这段应该使用
TextToSpeech::stop而不是使用空字符串。或许还有测试的含义，但是空字符串也可能是非法的字符串被TTS拒绝。