Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce gear-tasks #4017

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

feat: Introduce gear-tasks #4017

wants to merge 47 commits into from

Conversation

ark0f
Copy link
Member

@ark0f ark0f commented Jun 18, 2024 •
edited
Loading

Corresponding Substrate patches: gear-tech/polkadot-sdk#5

ark0f added 25 commits May 30, 2024 22:22
@ark0f
Initial implementation
ea81b9a
@ark0f
Add smoke test
67cde59
@ark0f
Add WASM smoke test
4531d2b
@ark0f
Fix no_std compilation
d79a1ed
@ark0f
Fix running tasks in WASM
cfaaa8c
@ark0f
Use self argument instead of manual ext obtaining
f44549e
@ark0f
RuntimeTasks -> GearTasks
e12f558
@ark0f
Execute WASM tasks via client
0ad2708
@ark0f
Spawn GearTasksRunner in pallet benchmarks
3bdec62
@ark0f
Fix WASM compilation
789141b
@ark0f
Read storage in benchmark test
d36995b
@ark0f
Initial denial of writes in tasks
36f8a6b
@ark0f
Support storage access in native
05aa81e
@ark0f
Propagate panic from thread
d9c3b53
@ark0f
Don't allow external API usage
0665964
@ark0f
Remove unused imports
226ff64
@ark0f
Update Substrate
286216d
@ark0f
Copy current overlay to thread
9359d1e
@ark0f
Panic in runtime API implementation in non-test env
89179c4
@ark0f
Docs for GearTasksContextExt
6511f87
@ark0f
Update Substrate
62bdeec
@ark0f
Clean up deps
77a95ba
@ark0f
Fix check for native function conversion
9a2cf65
@ark0f
Merge remote-tracking branch 'origin/master' into al/sp-tasks
cd6415a 
# Conflicts:
#	Cargo.lock
#	runtime-interface/Cargo.toml
#	runtime-interface/src/lib.rs
@ark0f
Update Cargo.lock
87aa4ad
@ark0f ark0f added the D2-node Gear Node label Jun 18, 2024
@ark0f ark0f marked this pull request as ready for review June 20, 2024 18:47
@ark0f ark0f added the A0-pleasereview PR is ready to be reviewed by the team label Jun 20, 2024
@ark0f ark0f added E2-forcemacos Force CI to run macOS build in PR E1-forcenatwin Force CI to run native Windows build in PR labels Jun 20, 2024
@clearloop clearloop mentioned this pull request Jun 23, 2024
Closed
@ark0f ark0f added E3-forcerelease Force CI to run release build in PR and removed E2-forcemacos Force CI to run macOS build in PR E1-forcenatwin Force CI to run native Windows build in PR labels Jun 25, 2024
@clearloop clearloop mentioned this pull request Jun 26, 2024
Merged
3 tasks
breathx
breathx requested changes Jul 11, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider throwing immutable refs to overlay for threads both on gear and substrate side as discussed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clearloop clearloop clearloop left review comments

@breathx breathx breathx requested changes

@ekovalev ekovalev Awaiting requested review from ekovalev

@ukint-vs ukint-vs Awaiting requested review from ukint-vs

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team D2-node Gear Node E3-forcerelease Force CI to run release build in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ark0f @clearloop @breathx