Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Add gr_user_break syscall to replace all non returning syscalls. #3662

Closed
wants to merge 2 commits into from

Conversation

mqxf
Copy link
Contributor

@mqxf mqxf commented Jan 13, 2024

Resolves #3216

@reviewer-or-team

@mqxf mqxf added A0-pleasereview PR is ready to be reviewed by the team D1-core Gear Core C2-refactoring Refactoring proposal labels Jan 13, 2024
@breathx
Copy link
Member

breathx commented Jan 14, 2024

First of all, the issue is already solved. No idea why GitHub shows only reference.
Secondly, you can't just remove support for some already existing on-chain calls

@breathx breathx closed this Jan 14, 2024
@breathx breathx deleted the ms/issue-3216 branch January 14, 2024 00:35
@mqxf
Copy link
Contributor Author

mqxf commented Jan 14, 2024

The issue wasn't solved, since he mentioned two syscalls, gr_system_break, which was solved, and gr_user_break, which wasn't. I asked around before making this issue and I am not removing any support, we are just moving any syscalls that dont return into one syscall, since they don't take many arguments.

@breathx
Copy link
Member

breathx commented Jan 14, 2024

The issue wasn't solved, since he mentioned two syscalls, gr_system_break, which was solved, and gr_user_break, which wasn't.

#3512 (review) It was discussed that other changes are redundant and incorrect.

I asked around before making this issue and I am not removing any support, we are just moving any syscalls that dont return into one syscall, since they don't take many arguments.

As I can see, you've removed support for previously existing programs, because old signatures of syscalls no longer exist.

@mqxf
Copy link
Contributor Author

mqxf commented Jan 16, 2024

I see. A bit of a stretch, but if this is useful enough, could some sort of "migrations" be used, where when a program is loaded, I could write some code which would check if it imports syscalls and replace the uses of those syscalls with the new break syscall? Probably not, but just an idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team C2-refactoring Refactoring proposal D1-core Gear Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: introduce gr_break
2 participants