Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wasm-builder): Check all gear requirements for code at compile time #3649

Merged
merged 21 commits into from
Jan 26, 2024
Merged

feat(wasm-builder): Check all gear requirements for code at compile time #3649

merged 21 commits into from
Jan 26, 2024

Conversation

mqxf
Copy link
Contributor

@mqxf mqxf commented Jan 9, 2024

Resolves #2819

@reviewer-or-team

@mqxf mqxf added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed C1-feature Feature request D5-tooling Helper tools and utilities labels Jan 9, 2024
techraed
techraed reviewed Jan 16, 2024
View reviewed changes
core/src/code.rs Outdated Show resolved Hide resolved
@shamilsan shamilsan changed the title feat(wasm-builder): Check all gear requirenments for code at compile time feat(wasm-builder): Check all gear requirements for code at compile time Jan 16, 2024
@mqxf
Copy link
Contributor Author

mqxf commented Jan 17, 2024

Still need to know whether I should implement a check for calling forbidden syscalls from handle_signal

@StackOverflowExcept1on
Copy link
Member

@mqxf handle_signal check is difficult to implement due to dynamic functions in wasm format

@mqxf mqxf added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Jan 18, 2024
@mqxf mqxf requested a review from breathx January 25, 2024 13:23
@shamilsan shamilsan added the B1-releasenotes The feature deserves to be added to the Release Notes label Jan 25, 2024
@mqxf mqxf mentioned this pull request Jan 26, 2024
Closed
@NikVolf NikVolf merged commit 10aa7f0 into master Jan 26, 2024
10 checks passed
@NikVolf NikVolf deleted the ms/issue-2819 branch January 26, 2024 15:31
breathx pushed a commit that referenced this pull request Feb 27, 2024
@mqxf @StackOverflowExcept1on @breathx
feat(wasm-builder): Check all gear requirements for code at compile…
2786007 
… time (#3649)

Co-authored-by: StackOverflowExcept1on <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikVolf NikVolf NikVolf approved these changes

@StackOverflowExcept1on StackOverflowExcept1on StackOverflowExcept1on approved these changes

@techraed techraed Awaiting requested review from techraed

@breathx breathx Awaiting requested review from breathx

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team B1-releasenotes The feature deserves to be added to the Release Notes C1-feature Feature request D5-tooling Helper tools and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check all gear requirements for code at build
5 participants
@mqxf @StackOverflowExcept1on @NikVolf @techraed @shamilsan