feat(gear-programs): Wrapped Vara (tokenizer) program extends VftService #129
Conversation
… into vo/vara-tokenizer
| edition.workspace = true | ||
|
|
||
| [dependencies] | ||
| vara-tokenizer-app = { path = "app" } |
There was a problem hiding this comment.
I would place that and all its deps (client, etc) in the workspace's Cargo.toml and use like .workspace = true
There was a problem hiding this comment.
It is from sails template. Main crate referenced in the workspace's Cargo.toml. The -app crate is intended for internal use only.
There was a problem hiding this comment.
But it makes sense if you're referring to a service from another.
| pub admins: HashSet<ActorId>, | ||
| } | ||
|
|
||
| static_storage!(AdminConfig); |
There was a problem hiding this comment.
It is better to keep it in the program's state from my point of view
There was a problem hiding this comment.
Methods storage and storage_mut are generated by macro, which may conflict with other storages.
It is better to use in the service module.
| @@ -0,0 +1,177 @@ | |||
| use sails_rs::{calls::*, gtest::calls::*, prelude::*}; | |||
There was a problem hiding this comment.
do we really need to have both tests for gclient and gtest? To tell the truth I personally prefer gclient only
There was a problem hiding this comment.
But the gclient tests require a running node and a lot of time to run.
So they marked as ignored by default.
I think we should have both.
There was a problem hiding this comment.
Waiting for
- repository for
vftservice to depend on instead of copying code: here https://github.com/gear-tech/awesome-sails - How to reply with value sails#475
as discussed in DM
vobradovich
changed the title
No description provided.