catch innermost spec context timeout #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
force-pushed
the
panic-at-the-disco
branch
from
9a3d138
to
3b618f6
Compare
In order to prevent the panic() that occurs if a context timeout cancel() function fires in the Go testing tool, we execute each test spec in its own goroutine and catch the individual cancel() function firing in order to properly output a failed assertion instead of a panic. Issue gdt-dev#37 Signed-off-by: Jay Pipes <[email protected]>
jaypipes
force-pushed
the
panic-at-the-disco
branch
from
3b618f6
to
4cff4c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent the panic() that occurs if a context timeout cancel() function fires in the Go testing tool, we execute each test spec in its own goroutine and catch the individual cancel() function firing in order to properly output a failed assertion instead of a panic.
Issue #37