Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Extracting out Main Scaffold and uses Dynamic Param by Arguments #5

Merged
merged 1 commit into from
Aug 31, 2024
Merged

[Improvement] Extracting out Main Scaffold and uses Dynamic Param by Arguments #5

merged 1 commit into from
Aug 31, 2024

Conversation

isfaaghyth
Copy link
Member

  • Implement dynamic param by arguments
  • Created ScreenScaffold for unification

@isfaaghyth
feat: improve scaffold ownership and fixes route path
6aa17e5 
* implement dynamic param by arguments
* created ScreenScaffold for unification
@isfaaghyth isfaaghyth self-assigned this Aug 31, 2024
@github-actions GitHub Actions
Copy link

Code Coverage

File Coverage [0.00%] ❌
app/src/commonMain/kotlin/id/gdg/app/App.kt 0.00% ❌
app/src/commonMain/kotlin/id/gdg/app/ui/AppRouter.kt 0.00% ❌
app/src/commonMain/kotlin/id/gdg/app/ui/ScreenScaffold.kt 0.00% ❌
app/src/commonMain/kotlin/id/gdg/app/ui/screen/MainScreen.kt 0.00% ❌
Total Project Coverage 27.61% ❌

@isfaaghyth isfaaghyth merged commit 9fc2b35 into main Aug 31, 2024
4 checks passed
@isfaaghyth isfaaghyth deleted the isfa/dynamic-route branch August 31, 2024 09:44
isfaaghyth added a commit that referenced this pull request Aug 31, 2024
@isfaaghyth
feat: promote scaffold as parent container and uses dynamic route path (
7141d2a 
#5)

* implement dynamic param by arguments
* created ScreenScaffold for unification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@isfaaghyth isfaaghyth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@isfaaghyth