Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html #171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update index.html #171

wants to merge 1 commit into from

Conversation

pauly7300
Copy link

Enabled search by uncommenting the search behavior.

enabled search
@pauly7300
Copy link
Author

Hope I did this correctly. I really like being able to search the docs. I also wrote an issue but then read up on docsify a bit and figure it out.

@gcobb321
Copy link
Owner

I understand you like the search function but I will not be approving this pull request. I found found the search results confusing and difficult to use. This pull request basically reverses a decision I made a while ago. I’ll look for another means of indexing and searching when I can. I’ll also look at that search code and see if it can be improved.

The docsuify site has a lot of examples of other users. I have gone through them looking for components they have implemented. Perhaps you can look for an indexing component someone has used. I’ll try it out on my test system and see if it is something that will work better than the existing one.

@pauly7300
Copy link
Author

Thanks much for the reply Gary. I'll see if I can find something else that might fit the bill. I don't disagree with your comment about the results being confusing. I just thought something is better than nothing but agree it should be a great solution before using. Thanks again!

Cheers,
Paul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants