Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another tone notation #21

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Another tone notation #21

wants to merge 5 commits into from

Conversation

zsinx6
Copy link
Contributor

@zsinx6 zsinx6 commented Jul 17, 2018

No description provided.

@zsinx6
Copy link
Contributor Author

zsinx6 commented Oct 2, 2018

@gciruelos can you merge this?

@gciruelos
Copy link
Owner

thank you for pinging me, whenever I don't respond please do

Please remove accents from the note names, let's keep everything in English.
Also please give the variables of the new class a better name, because Do Re Mi... are not letters

@zsinx6
Copy link
Contributor Author

zsinx6 commented Oct 2, 2018

thank you for pinging me, whenever I don't respond please do

Please remove accents from the note names, let's keep everything in English.
Also please give the variables of the new class a better name, because Do Re Mi... are not letters

Since I'm sub classing the Letter class, when renaming the variables, everything must be re-implemented. Or am I missing something?

@gciruelos
Copy link
Owner

Yes, I think in this case refactoring the Letter class might be the easiest.

fferri
fferri reviewed Jul 11, 2023
View reviewed changes
musthe/musthe.py
"""
Another tone naming.

There are still 7: Dó, Ré, Mi, Fá, Sol, Lá, and Si.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since these names are language-dependent, consider using locale, reading LC_* env, or accepting a lang option to get those name in the desired locale?

@gciruelos
Copy link
Owner

Please resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fferri fferri fferri left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zsinx6 @gciruelos @fferri