-
Notifications
You must be signed in to change notification settings - Fork 57
CueRipper with Tracks in a DataGridView #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ge (gchudov#115), Add option Block Eject while Ripping, Fix Eject/Insert CD bug (gchudov#120)
…taGridView control. Added multiple cell selecting, copying, pasting and deleting.
# Conflicts: # Bwg.Scsi/Device.cs # CUERipper/Options.cs # CUERipper/frmCUERipper.Designer.cs # CUERipper/frmCUERipper.cs # CUERipper/frmCUERipper.resx # CUETools.Processor/CUEConfig.cs # CUETools.Ripper.SCSI/SCSIDrive.cs # CUETools.Ripper/Ripper.cs
|
Pre-release test build incomplete. Particularly Composer & Lyricist are not supported by CTDB and no tags were written after a test run with manually entered data. Also not saved to or read from the MetadataCache. |
… fields Composers, Lyrics and ISRC. Tag Lyricist(s) doesn't exist in library Taglib-sharp, so tag Lyrics is used. Also the last columns in the DataGridView are predefined in the resources. ISRC information is shown after scanning Gaps.
I haven't looked at the plugins yet. |
|
user perspective
I do not believe that will be acceptable to users. ISRC and gaps require gap detection so this information is only available to the normal user after the rip is complete. I am uncertain that the columns serve a purpose pre-extraction. Pre-emphasis and copyright flags can be located in subcode or TOC or both. I have not tested to see if TOC info is shown pre-extraction but subcode would require gap detection. I am uncertain that the columns serve a purpose pre-extraction. |
From the CD rippers perspective it would make sense. Lyrics are not available while ripping, so the tag Lyrics is unused. What would you suggest for the Lyricists data?
ISRC and gaps info is available right after the start of ripping. The first phase is gap detection and the info is displayed before the actual ripping of the tracks is done.
That way it showed me the problem with the created .cue file with the default gap mode (CUEStyle.GapsAppended). See Generated CUE file format problem #268. A possible solution is included in the current code as comment. |
I don't have a suggestion at the moment. The correct ID3v2 tag would be TEXT instead of USLT. If I'm not mistaken, taglib-sharp is somewhat configurable. CUERipper already uses some custom tags.
The window shifts to left when ripping begins so unless in full screen mode the info isn't viewable.
Not sure where you are going here. IF issue #268 were to be addressed, it should be done in a separate PR. The Non-Compliant CUE in the issue is intentional and SHOULD NOT be removed. Currently CUETools can read the Non-Compliant CUE and merge the separate audio tracks [plus HTOA] into an Image+CUE with all gap info. You cannot remove that feature. I proposed a SETTING to provide an option for a Compliant CUE that also preserves GAP info but it would require quite a bit of work. |
I will look into that. Maybe I can use a custom tag.
With the window you mean the information in the DataGridView? The column widths and positions can be altered (and are preserved). If one is interested the certain column can be moved to a position that is always visible.
Thank you for your elaborate answer. If have no intention to alter this without discussion/consultation. In the latest version I have changed the way the UI is updated while ripping. Not directly after each read, what causes a high CPU usage, but with a timer of 100ms. It lowers the CPU usage significantly. |
Fixed. Tags for Lyricist are shown in the MP3TagEditor (under Popupmenu=>Tags...) with FLAC and MP3 files. With ID3V2 the frame TEXT is used. With XIPH (FLAC) the tag LYRICIST is created. Can the additions now be merged in the main branch? |
CueRipper with tracks shown in a DataGridView. Multiple cells can be copied, pasted or deleted.
Multiple selection by holding Ctrl or Shift and mouse click or arrow keys.
Copying (Ctrl+C) puts the selected cells separated with tabs on the Clipboard so it can be edited in i.e. LibreOffice Calc or Excel. Can be used for easy splitting text cells containing both the artist and track name by pasting in Calc with Ctrl+Shift+V.
When multiple cells are selected before pasting (Ctrl+V) the cells get all the same value.
When a single cell is selected before pasting, multiple cells (if available on the clipboard) are pasted,
Deleting single or multiple cells with (Ctrl+Del)
Cutting (Ctrl+X) is copying and deleting combined.
Column Headers size and position can be adjusted and are automatically saved.
Pre-release here: https://github.com/RDamman/cuetools.net/releases
Multiple selection and copying the clipboard:

Import in Calc:

Result in Calc:

Paste in CueRipper:

Copy separated cells:

Paste separated cells in other column:

Select multiple cells for pasting same value (by holding Ctrl and click):

Values pasted:
