Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for writing dummy CUE sheet comment #347

Conversation

c72578
Copy link
Collaborator

@c72578 c72578 commented Sep 4, 2024

If desired, this setting allows disabling writing of the following
comment in dummy CUE sheets:
REM COMMENT "CUETools generated dummy CUE sheet"

  • Add setting:
    WriteDummyCUESheetComment
    Default:
    WriteDummyCUESheetComment=1
    The setting is enabled by default, to preserve previous behavior.
  • The setting can be modified by editing settings.txt after
    closing CUETools:
    Use bool value 0, to disable writing the dummy CUE sheet comment.
  • Resolves: Generated CUE file comment #343

If desired, this setting allows disabling writing of the following
comment in dummy CUE sheets:
REM COMMENT "CUETools generated dummy CUE sheet"

- Add setting:
  `WriteDummyCUESheetComment`
  Default:
  `WriteDummyCUESheetComment=1`
  The setting is enabled by default, to preserve previous behavior.
- The setting can be modified by editing `settings.txt` after
  closing CUETools:
  Use bool value 0, to disable writing the dummy CUE sheet comment.
- Resolves: gchudov#343
@c72578
Copy link
Collaborator Author

c72578 commented Sep 4, 2024

Here is a build for testing:

CUETools_2.2.6_2024-09-04_git_9ed297b_Add_setting_for_writing_dummy_CUE_sheet_comment.zip
SHA256: 96fa9a6c301a8b6b87ec6bc7b5b5f93cb65a077450abbb3537f4c5e5f3106f4b

@acmodeu, please have a look, if this works as desired.

@acmodeu
Copy link

acmodeu commented Sep 5, 2024

Yep, thank you, works exactly as expected!

@c72578 c72578 merged commit 9ed297b into gchudov:master Sep 7, 2024
1 check passed
@ha-korth
Copy link

ha-korth commented Sep 15, 2024

I noticed that the setting can be changed in CUERipper (setting does not revert back to '1' when CUERipper is restarted).
Not a big deal. There are many settings in CUERipper's settings.txt that don't do anything if changed.
However, CUERipper does have it's own 'default' comment REM COMMENT "CUERipper v2.2.6 Copyright (C) 2008-2024 Grigory Chudov" that can only be removed by editing the comment field before ripping.
Maybe this setting could have been WriteDefaultCUESheetComment ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated CUE file comment
3 participants