Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SCSIDrive.cs to add support for LITEON ADH20A4P9P57 devices #328

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

TomDSilva
Copy link
Contributor

Added "ADH20A4P9P57" to the list of devices to use Mode296 as this device is not compatible with Mode294.

Added "ADH20A4P9P57" to the list of devices to use Mode296.
@TomDSilva
Copy link
Contributor Author

TomDSilva commented Jun 3, 2024

Using a LITEON external USB DVD drive - model DX-20A4P throws the following error when ripping a CD:
image

Upon testing, this appears to be because the hardware does not support Mode294 and needs to use Mode296.
Using the code change I want to merge fixes this issue.

Here is a picture of the drive:
image

And here is how the drive shows when in Visual Studio:
image
I have elected to target the drive name of "ADH20A4P9P57" as I believe this may be picked up also if the drive is used internally rather than in a USB enclosure as I am using (as I am omitting the "ATAPIDVD" part).

Please let me know if more information is needed, or if there is anything I need to change.

Thanks.

@c72578
Copy link
Collaborator

c72578 commented Jun 3, 2024

@TomDSilva Thanks for your PR.
Could you please post a screenshot of CUERipper showing the detected drive?
It looks like the firmware version 9P57 is included in the string ADH20A4P9P57, which is not necessary.

DH20A4P is probably sufficient as identifier.
https://www.daefeatures.co.uk/search?model=20A4P

Amended target device to just "DH20A4P".
@TomDSilva
Copy link
Contributor Author

@c72578 of course:
image

Just "DH20A4P" works, you are correct, thanks for the explanation.
I have amended the commit to just target "DH20A4P", is that okay? I have never committed to someone else's work, so please be patient with me. :)

@c72578
Copy link
Collaborator

c72578 commented Jun 4, 2024

Could you please move the added lines for the LITEON drive between the LG and MATSHITA drives? The lines are sorted alphabetically by manufacturer.

@TomDSilva
Copy link
Contributor Author

@c72578, of course - done.
Please let me know if anything more is needed.

Moved the added lines for the LITEON drive to between the LG and MATSHITA drives as the lines are sorted alphabetically by manufacturer.
@c72578 c72578 force-pushed the FixC2ErrorMode-ADH20A4P9P57 branch from 75cbe8c to 907f88d Compare June 6, 2024 19:48
@c72578 c72578 merged commit 1dce40c into gchudov:master Jun 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants