4453 compaction creation batch files are never deleted #4599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca61688
reviewed
Apr 8, 2025
...n-job-creation/src/main/java/sleeper/compaction/job/creation/AwsCompactionJobDispatcher.java
Show resolved
Hide resolved
patchwork01
reviewed
Apr 8, 2025
There was a problem hiding this comment.
Since the current AWS code for this does nothing, we could still merge these changes and it wouldn't cause a problem. To actually fix the bug, we still need to add the missing assertions and implement it against SQS.
If we want to merge this as is, we could split out a separate issue for just these changes, and link this PR to that instead. Right now this PR is linked to the actual bug issue so it'll close it if it's merged, and it isn't fixed yet.
...ion-core/src/test/java/sleeper/compaction/core/job/dispatch/CompactionJobDispatcherTest.java
Show resolved
Hide resolved
...ion-core/src/test/java/sleeper/compaction/core/job/dispatch/CompactionJobDispatcherTest.java
Show resolved
Hide resolved
Rob9786
force-pushed
the
4453-compaction-creation-batch-files-are-never-deleted
branch
from
a01d744 to
e787485
Compare
patchwork01
reviewed
Apr 10, 2025
...ion-core/src/test/java/sleeper/compaction/core/job/dispatch/CompactionJobDispatcherTest.java
Outdated
Show resolved
Hide resolved
...paction-core/src/main/java/sleeper/compaction/core/job/dispatch/CompactionJobDispatcher.java
Outdated
Show resolved
Hide resolved
...ion-core/src/test/java/sleeper/compaction/core/job/dispatch/CompactionJobDispatcherTest.java
Show resolved
Hide resolved
patchwork01
reviewed
Apr 10, 2025
...ion-core/src/test/java/sleeper/compaction/core/job/dispatch/CompactionJobDispatcherTest.java
Outdated
Show resolved
Hide resolved
patchwork01
approved these changes
Apr 11, 2025
...ion-core/src/test/java/sleeper/compaction/core/job/dispatch/CompactionJobDispatcherTest.java
Show resolved
Hide resolved
...job-creation/src/test/java/sleeper/compaction/job/creation/AwsCompactionJobDispatcherIT.java
Show resolved
Hide resolved
rtjd6554
approved these changes
Apr 11, 2025
rtjd6554
deleted the
4453-compaction-creation-batch-files-are-never-deleted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Issue
PR"
Tests
Documentation
separate issue for that below.