Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tree recombination #504

Merged
merged 15 commits into from
Sep 8, 2024
Merged

Feature/tree recombination #504

merged 15 commits into from
Sep 8, 2024

Commits on Jul 31, 2024

  1. feat: simplify Coresubset.coreset materialization

    Additionally enhances coreset testing.
    tc85324 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    20d9d40 View commit details
    Browse the repository at this point in the history
  2. feat: add Caratheodory and Tree recombination.

    Adds a new `recombination.py` module to the solvers subpackage,
    providing a generalised `RecombinationSolver`, in addition to the
    `CaratheodoryRecombination` and `TreeRecombination` solvers.
    
    A `RecombinationSolverTest` case has been added to `test_solvers.py`,
    covering the known degenerate cases that may arise in recombination.
    
    The documentation has been updated where required, but no dedicated
    new examples/documentation pages have been created.
    
    Refs: #497
    tc85324 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    421c74d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fbe7f2b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    52839ef View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Configuration menu
    Copy the full SHA
    f05b0ac View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Configuration menu
    Copy the full SHA
    124cfe9 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Configuration menu
    Copy the full SHA
    13fa00d View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. fix: improve docs and code comments.

    Performed in response to reviewer comments on #504
    tc85324 committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    10a1d5b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cb19de5 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. docs: add missing recombination theorem references

    Adds references to the original articles for Tchakaloff's theorem and
    Caratheodory's convex hull theorem (in French/German respectively), in
    addition to more recent, but for our purposes equivalent, references
    written in English.
    tc85324 committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f533e56 View commit details
    Browse the repository at this point in the history
  2. docs: add comments to recombination algorithms

    Makes clearer the correspondence between the Caratheodory recombination
    algorithm implemented here, and the thesis of Tchernychova. Provides
    additional clarity on the steps performed in Tree recombination.
    tc85324 committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    43493b7 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. fix: missed pyright complaints

    Corrects some simple to fix pyright linting errors.
    tc85324 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f0cdf80 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7fecf80 View commit details
    Browse the repository at this point in the history
  3. fix(regression): remove int cast

    In attempting to placate the pyright linter a new, erroneous change
    was made to the logic in `_resolve_null_basis`. This has been fixed
    and the type hints updated appropriately.
    tc85324 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    4a620be View commit details
    Browse the repository at this point in the history
  4. fix(regression): _ElementOfOmega TypeVar

    Apparent runtime incompatibility with jaxtyping. Appears that the
    `Shaped[TypeVar, ...]` syntax used for `_ElementOfOmega is not
    supported (even if the TypeVar is bound by Array).
    tc85324 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9fc766b View commit details
    Browse the repository at this point in the history