Gh-3237 Implement DeleteElements for Map Store #3239
Conversation
core/operation/src/main/java/uk/gov/gchq/gaffer/operation/impl/delete/DeleteElements.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3239 +/- ##
=============================================
+ Coverage 67.07% 67.15% +0.07%
- Complexity 2558 2569 +11
=============================================
Files 919 921 +2
Lines 29492 29619 +127
Branches 3288 3296 +8
=============================================
+ Hits 19782 19890 +108
- Misses 8261 8277 +16
- Partials 1449 1452 +3 ☔ View full report in Codecov by Sentry. |
core/operation/src/main/java/uk/gov/gchq/gaffer/operation/impl/delete/DeleteElements.java
Outdated
Show resolved
Hide resolved
...entation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/DeleteElementsHandler.java
Outdated
Show resolved
Hide resolved
...entation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/DeleteElementsHandler.java
Outdated
Show resolved
Hide resolved
...entation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/DeleteElementsHandler.java
Outdated
Show resolved
Hide resolved
...entation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/DeleteElementsHandler.java
Outdated
Show resolved
Hide resolved
...entation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/DeleteElementsHandler.java
Show resolved
Hide resolved
I think the duplication is largely due to a wider issue where many of the core classes used here are interfaces which expect class instance variables in the implementing classes. This results in all implementing classes creating the same variables and method overrides, one way to fix this would be to use abstract classes where appropriate instead but it is a larger problem to fix. |
...entation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/DeleteElementsHandler.java
Outdated
Show resolved
Hide resolved
| @@ -412,6 +413,11 @@ protected OutputOperationHandler<GetTraits, Set<StoreTrait>> getGetTraitsHandler | |||
| return new GetTraitsHandler(TRAITS); | |||
| } | |||
|
|
|||
| @Override | |||
| protected OperationHandler<? extends DeleteElements> getDeleteElementsHandler() { | |||
| return null; | |||
There was a problem hiding this comment.
I know we are going to implement the accumulo logic but could we return an empty handler that does nothing instead. Just good practice. Or put a comment in to say we will revisit it.
...entation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/DeleteElementsHandler.java
Outdated
Show resolved
Hide resolved
store-implementation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/MapImpl.java
Outdated
Show resolved
Hide resolved
|
Related issue