Add new operations: AES Key Wrap/Unwrap With Padding #2053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aosterhage
commented
May 26, 2025
| cipher.finish(); | ||
| output = cipher.output.getBytes(); | ||
| } else { | ||
| // Otherwise, follow the wrapping process from RFC 3394 (AESKeyWrap operation). |
There was a problem hiding this comment.
Is there a mechanism to programmatically call another operation? That would be preferable to the copy/paste that has been done here (since this is just the "AES Key Wrap" operation).
For anyone not familiar with RFC 5649, it does not make sense to try to force this operation to only handle padding for two reasons:
- It contains a special wrapping case when the padded input is exactly 8 octets (that does not adhere to RFC3394).
- The padding operations would need to pass multiple values (both the padded plaintext as well as the AIV) between the AES Key Wrap/Unwrap operations when chained together.
There was a problem hiding this comment.
Is there a mechanism to programmatically call another operation?
If that doesn't exist, I suppose an appropriate thing to do is to move the RFC 3394 algorithm into a shared utility.
There was a problem hiding this comment.
If that doesn't exist, I suppose an appropriate thing to do is to move the RFC 3394 algorithm into a shared utility.
This is now done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Advanced Encryption Standard (AES) Key Wrap with Padding Algorithm is defined in RFC 5649. It utilizes the key wrapping algorithm defined in RFC 3394 but enables the "key" being wrapped to be of any length.