Skip to content

Commit

Permalink
Fixed bug where popovers on operations stopped working after the oper…
Browse files Browse the repository at this point in the history
…ation was dragged into the recipe.
  • Loading branch information
n1474335 committed Apr 27, 2017
1 parent be231f3 commit e4c5c4a
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/web/RecipeWaiter.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,21 +76,25 @@ RecipeWaiter.prototype.initialiseOperationDragNDrop = function() {
/**
* Creates a drag-n-droppable seed list of operations.
*
* @param {element} listEl - The list the initialise
* @param {element} listEl - The list to initialise
*/
RecipeWaiter.prototype.createSortableSeedList = function(listEl) {
Sortable.create(listEl, {
group: {
name: "recipe",
pull: "clone",
put: false
put: false,
},
sort: false,
setData: function(dataTransfer, dragEl) {
dataTransfer.setData("Text", dragEl.textContent);
},
onStart: function(evt) {
// Removes popover element and event bindings from the dragged operation but not the
// event bindings from the one left in the operations list. Without manually removing
// these bindings, we cannot re-initialise the popover on the stub operation.
$(evt.item).popover("destroy");
$(evt.clone).off(".popover").removeData("bs.popover");
evt.item.setAttribute("data-toggle", "popover-disabled");
},
onEnd: this.opSortEnd.bind(this)
Expand Down

0 comments on commit e4c5c4a

Please sign in to comment.