Add tree trait #43
Closed
Add tree trait #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, set the number of children reported by Node::Branch to 16 instead of the number of non-empty nodes.
gballet
commented
Nov 13, 2019
| // Was it an extension of 1 ? If so, place the node directly | ||
| // otherwise truncate the extension. | ||
| res[extkey[0] as usize] = if extkey.len() == 1 { | ||
| child.clone() |
There was a problem hiding this comment.
Note to self: it should be possible to get rid of these clones.
|
Superseded by #44 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the ground for supporting several tree formats. This addresses #10 and supersedes #42
As a result, it adds a trait
Treethat supports operations like insertion and iteration over the set of child nodes, then re-implementsNodein terms of this trait.