Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LAT LON max #19

Merged
merged 2 commits into from
Jan 1, 2023
Merged

Update LAT LON max #19

merged 2 commits into from
Jan 1, 2023

Conversation

JJardin77580
Copy link
Contributor

@JJardin77580 JJardin77580 commented Dec 19, 2022

IN RFC 7946 https://www.rfc-editor.org/rfc/rfc7946, the Latitude can be in the range -90 and 90 and longitude in the range -180 & 180 INCLUDE.

In this pr I therefore propose to do a check with GTE and LTE to include these limit values..

IN RFC 7946 https://www.rfc-editor.org/rfc/rfc7946, the Latitude can be in the range -90 and 90 *INCLUDE*. 
In this pr I therefore propose to do a check with GTE and LTE to include these limit values..
@folt folt added the bug Something isn't working label Dec 19, 2022
@folt
Copy link
Collaborator

folt commented Dec 19, 2022

Good point. You can add multiple tests for a given value. Feel free to add yourself to AUTHORS as Contributors

@JJardin77580
Copy link
Contributor Author

@folt it's good for me 😄 For you too ?

@folt
Copy link
Collaborator

folt commented Jan 1, 2023

Good job

@folt folt merged commit e9e82ba into gb-libs:master Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants