Replace setup.{cfg,py} with pyproject.toml #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbohdan
force-pushed
the
pyproject
branch
5 times, most recently
from
4433c44 to
2d2e923
Compare
|
I had to make several corrections and to rebase my branch on your |
dbohdan
force-pushed
the
pyproject
branch
3 times, most recently
from
d735505 to
2460500
Compare
This gives better indication what kind of error has occurred.
gawel
reviewed
Apr 11, 2025
Remove Trove classifiers for specific Python 3 versions as redundant. Replace `from aiohttp import wsgi` with aiohttp-wsgi. aiohttp.wsgi was dropped in aio-libs/aiohttp#1108. Test in Python 3.13. This migration keeps tox.ini for two reasons: 1. tox only added support for native TOML configuration in recent version 4.21. 2. Flake8 doesn't support TOML configuration without a third-party package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the project from
setup.{cfg,py}topyproject.toml. It removes Trove classifiers for Python versions as redundant, replaces deprecatedfrom aiohttp import wsgiwith aiohttp-wsgi, and updates GitHub Actions CI. In GitHub Actions, it adds Python 3.13 tests and separates flake8/docs from tests proper. This gives better indication what kind of error has occurred.The PR keeps
tox.inibecause of two tools:Resolves #215.