Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix login page dark mode texts #596

Conversation

akshay0712-dev
Copy link
Contributor

@akshay0712-dev akshay0712-dev commented Nov 5, 2024

🚀 Pull Request

Description
This pull request addresses an issue with text visibility on the login page when in dark mode. The changes ensure that all text elements adjust their color appropriately, improving readability and maintaining consistency with the overall dark mode theme.


Related Issue
Close #591


Type of Change
What kind of change does this pull request introduce?

  • 🐛 Bug fix
  • 🚀 New feature
  • 📄 Documentation update
  • 🛠️ Code improvement/refactor
  • 🖼️ UI/UX update
  • Other (please specify)

Screenshots (if applicable)
before
img2

after
img1


Checklist
Please ensure the following tasks are complete before submitting the pull request:

  • I have tested my changes and ensured they work as expected.
  • I have added any necessary documentation or comments.
  • I have checked the existing issues and pull requests to avoid duplicates.
  • I have starred this repository.
  • I have reviewed my code for best practices and readability.
  • I have included any relevant tests (if applicable).

Additional Context
Fix #591 The text color adjustments were made to adapt dynamically based on the active theme, ensuring consistency and accessibility across light and dark modes.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for visionary-fenglisu-db1b1d ready!

Name Link
🔨 Latest commit 07f6f85
🔍 Latest deploy log https://app.netlify.com/sites/visionary-fenglisu-db1b1d/deploys/672c51055415940008f55ea0
😎 Deploy Preview https://deploy-preview-596--visionary-fenglisu-db1b1d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gauravsingh1281
Copy link
Owner

hey @akshay0712-dev please resolve the merge conflicts.

@akshay0712-dev
Copy link
Contributor Author

hello @gauravsingh1281 I have fixed the conflicts. Now u can merge

@gauravsingh1281 gauravsingh1281 merged commit 68bdbbf into gauravsingh1281:main Nov 9, 2024
5 checks passed
@akshay0712-dev akshay0712-dev deleted the fix/text_in_dark_mode_in_login_page branch November 9, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]:TEXT NOT VISIBLE IN DARK MODE IN THE LOGIN PAGE
2 participants