Changed parameter type from String to &str #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yash Israni <[email protected]>
|
@yashisrani Thanks for looking into this. Could you fix the CI reported errors please? Also, in the meantime, let's keep the PR as draft. |
Signed-off-by: Yash Israni <[email protected]>
gauravgahlot
requested changes
Jan 28, 2025
@gauravgahlot Sir, I deleted the changelog.md file. I think now all is well in this pull request. I done some silly mistakes. sorry of that 😥. |
gauravgahlot
approved these changes
Jan 28, 2025
|
Thank you @yashisrani |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #26
Title: Change parameter type from String to &str
Description
Stringto&strto improve performance by avoiding unnecessary heap allocation.&str, and a lifetime parameter has been added to the struct for proper reference management.