fix(gatsby-graphiql-explorer): error when refresh button is rendered #39366
+93
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The refresh button was rendered without context, causing the graphiql explorer to crash into a white screen.
[email protected]added a new propadditionalComponentto address this error and render things with context.https://github.com/graphql/graphiql/releases/tag/[email protected]
https://github.com/graphql/graphiql/releases/tag/%40graphiql%[email protected]
This PR upgrades graphiql packages and uses the
additionalComponentprop to fix the error.Documentation
Bug fix, no documentation needed
Tests
This package doesn't have any tests. I tested by using
yarn linkin my projectRelated Issues
Fixes #38634