Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casting of client connections upon enumeration #584

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented Jul 31, 2024

Ticket(s)

N/A

Description

While testing the API I found out that the busy connections field is not being populated, hence causing the total field to be incorrect as well. The bug existed even before the new changes in #577, hence causing plugins, i.e. cache plugin, to intermittently fail.

Related PRs

N/A

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have updated docs using make gen-docs command.
  • I have added tests for my changes.
  • I have signed all the commits.

Legal Checklist

@mostafa mostafa added the bug Something isn't working label Jul 31, 2024
@mostafa mostafa added this to the v0.9.x milestone Jul 31, 2024
@mostafa mostafa self-assigned this Jul 31, 2024
Copy link

Overview

Image reference ghcr.io/gatewayd-io/gatewayd:fa62f34 gatewaydio/gatewayd:latest
- digest 22112f0dd279 93100deaec5d
- tag fa62f34 latest
- provenance f70e428
- vulnerabilities critical: 1 high: 0 medium: 0 low: 0 critical: 3 high: 1 medium: 3 low: 1 unspecified: 1
- platform linux/amd64 linux/amd64
- size 19 MB 17 MB (-2.1 MB)
- packages 133 128 (-5)
Base Image alpine:3
also known as:
3.20
3.20.2
latest
alpine:3.20
also known as:
3
latest
- vulnerabilities critical: 0 high: 0 medium: 0 low: 0 critical: 1 high: 0 medium: 2 low: 0 unspecified: 1
Packages and Vulnerabilities (35 package changes and 3 vulnerability changes)
  • ➕ 1 packages added
  • ➖ 5 packages removed
  • ♾️ 29 packages changed
  • 96 packages unchanged
  • ❗ 3 vulnerabilities added
Changes for packages of type apk (9 changes)
Package Version
ghcr.io/gatewayd-io/gatewayd:fa62f34
Version
gatewaydio/gatewayd:latest
♾️ busybox 1.36.1-r29 1.36.1-r28
♾️ busybox-binsh 1.36.1-r29 1.36.1-r28
ca-certificates 20240705-r0
♾️ ca-certificates-bundle 20240705-r0 20240226-r0
♾️ libcrypto3 3.3.1-r3 3.3.0-r2
♾️ libssl3 3.3.1-r3 3.3.0-r2
critical: 1 high: 0 medium: 0 low: 0
Added vulnerabilities (1):
  • critical : CVE--2024--5535
openssl 3.3.1-r3
pax-utils 1.3.7-r2
♾️ ssl_client 1.36.1-r29 1.36.1-r28
Changes for packages of type golang (26 changes)
Package Version
ghcr.io/gatewayd-io/gatewayd:fa62f34
Version
gatewaydio/gatewayd:latest
♾️ github.com/gatewayd-io/gatewayd (devel) 0.9.6
♾️ github.com/gatewayd-io/gatewayd-plugin-sdk 0.3.0 0.2.15
♾️ github.com/getsentry/sentry-go 0.28.0 0.27.0
♾️ github.com/go-logr/logr 1.4.2 1.4.1
github.com/munnerz/goautoneg 0.0.0-20191010083416-a7dc8b61c822
♾️ github.com/prometheus/common 0.55.0 0.53.0
♾️ github.com/prometheus/procfs 0.15.1 0.15.0
♾️ github.com/redis/go-redis/v9 9.5.4 9.5.1
♾️ github.com/spf13/cobra 1.8.1 1.8.0
♾️ github.com/wasilibs/go-pgquery 0.0.0-20240606042535-c0843d6592cc 0.0.0-20240510022537-eb0917feddeb
github.com/wasilibs/wazero-helpers 0.0.0-20240604052452-61d7981e9a38
♾️ go.opentelemetry.io/otel 1.27.0 1.26.0
♾️ go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc 1.27.0 1.26.0
♾️ go.opentelemetry.io/otel/metric 1.27.0 1.26.0
♾️ go.opentelemetry.io/otel/sdk 1.27.0 1.26.0
♾️ go.opentelemetry.io/otel/trace 1.27.0 1.26.0
♾️ golang.org/x/crypto 0.25.0 0.23.0
♾️ golang.org/x/net 0.27.0 0.25.0
♾️ golang.org/x/oauth2 0.21.0 0.20.0
♾️ golang.org/x/sys 0.22.0 0.20.0
♾️ golang.org/x/text 0.16.0 0.15.0
♾️ google.golang.org/genproto/googleapis/rpc 0.0.0-20240711142825-46eb208f015d 0.0.0-20240528184218-531527333157
♾️ google.golang.org/grpc 1.65.0 1.64.0
♾️ google.golang.org/protobuf 1.34.2 1.34.1
gopkg.in/yaml.v2 2.4.0
♾️ stdlib go1.22.5 1.22.3
critical: 1 high: 1 medium: 0 low: 0
Added vulnerabilities (2):
  • critical : CVE--2024--24790
  • high : CVE--2024--24791

@mostafa mostafa requested a review from sinadarbouy July 31, 2024 11:25
Copy link
Collaborator

@sinadarbouy sinadarbouy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@mostafa mostafa merged commit 6951811 into main Jul 31, 2024
5 checks passed
@mostafa mostafa deleted the fix-busy-connections-string branch July 31, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants