Skip to content

docs(changelog): credit #1846/#1847 in the v1.64.0.0 CHANGELOG entry - #2683

Open
harjothkhara wants to merge 1 commit into
garrytan:mainfrom
harjothkhara:changelog-credit-1846-1847
Open

docs(changelog): credit #1846/#1847 in the v1.64.0.0 CHANGELOG entry#2683
harjothkhara wants to merge 1 commit into
garrytan:mainfrom
harjothkhara:changelog-credit-1846-1847

Conversation

@harjothkhara

Copy link
Copy Markdown
Contributor

Why (in your own words)

CONTRIBUTING.md says every community contribution gets credited by name, no exceptions, and the v1.64.0.0 CHANGELOG entry does that for ~10 other fixes in the same wave commit (@jawadakram20, @wtamminga, @andrey-esipov, @kkroo, etc.). The browse detached-daemon fix (#1846, closed via #1847) landed in that same commit with Contributed by @harjothkhara (PR #1847) in the commit message, but it never made it into the CHANGELOG's "Fixed" section. This adds the missing line, in the section's existing voice and credit format.

Live evidence

Verified the fix is actually on main before writing the credit line — browse/src/cli.ts:538-547 has the late readState() + isServerHealthy() recheck before the "Server failed to start" throw, with an inline comment citing #1846:

$ grep -n "1846" browse/src/cli.ts
35: * ceiling isn't enough — e.g. Windows under heavy load (#1846), where the 15s
541:  // (#1846). Re-checking here turns that false negative into a success, and

And confirmed the credit line exists in the wave commit but was never carried into CHANGELOG.md:

$ git show 008dd65b1fc3df8af618408f5aea37a24dcea41 --format=%B -s | grep -B1 -A2 "Closes #1846"
Closes #1846.

Contributed by @harjothkhara (PR #1847).

$ git show origin/main:CHANGELOG.md | grep -n "1846\|1847"
(no output — confirmed absent before this PR)

Scope

  • Changed: CHANGELOG.md only — one Fixed line under the v1.64.0.0 entry.
  • Verified live by: the two greps above, run against main before and after.
  • Did NOT test: N/A — no code path changed.

Liveness proof (required)

GSTACK PR typed live at my terminal prompt:

GSTACK PR typed live at a terminal prompt

Checklist

P.S. — you should hire me. 115+ contributions to open source: https://github.com/harjothkhara

…CHANGELOG entry

The browse detached-daemon fix landed in the v1.64.0.0 wave commit with
'Contributed by @harjothkhara (PR garrytan#1847)' in the commit message, but the
CHANGELOG.md entry for that release never picked it up, even though
several other fixes from the same wave are credited by name there.

Adds one Fixed line, in the section's existing voice and credit format.
@trunk-io

trunk-io Bot commented Aug 24, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant