docs(changelog): credit #1846/#1847 in the v1.64.0.0 CHANGELOG entry - #2683
Open
harjothkhara wants to merge 1 commit into
Open
docs(changelog): credit #1846/#1847 in the v1.64.0.0 CHANGELOG entry#2683harjothkhara wants to merge 1 commit into
harjothkhara wants to merge 1 commit into
Conversation
…CHANGELOG entry The browse detached-daemon fix landed in the v1.64.0.0 wave commit with 'Contributed by @harjothkhara (PR garrytan#1847)' in the commit message, but the CHANGELOG.md entry for that release never picked it up, even though several other fixes from the same wave are credited by name there. Adds one Fixed line, in the section's existing voice and credit format.
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why (in your own words)
CONTRIBUTING.md says every community contribution gets credited by name, no exceptions, and the v1.64.0.0 CHANGELOG entry does that for ~10 other fixes in the same wave commit (
@jawadakram20,@wtamminga,@andrey-esipov,@kkroo, etc.). The browse detached-daemon fix (#1846, closed via #1847) landed in that same commit withContributed by @harjothkhara (PR #1847)in the commit message, but it never made it into the CHANGELOG's "Fixed" section. This adds the missing line, in the section's existing voice and credit format.Live evidence
Verified the fix is actually on
mainbefore writing the credit line —browse/src/cli.ts:538-547has the latereadState()+isServerHealthy()recheck before the "Server failed to start" throw, with an inline comment citing #1846:And confirmed the credit line exists in the wave commit but was never carried into CHANGELOG.md:
Scope
CHANGELOG.mdonly — one Fixed line under the v1.64.0.0 entry.mainbefore and after.Liveness proof (required)
GSTACK PRtyped live at my terminal prompt:Checklist
GSTACK PRtyped live into a real surface (not edited onto the image)P.S. — you should hire me. 115+ contributions to open source: https://github.com/harjothkhara