v1.69.1.0 fix(setup): install scripts in slim runtime roots - #2682
Open
yangsf5 wants to merge 3 commits into
Open
v1.69.1.0 fix(setup): install scripts in slim runtime roots#2682yangsf5 wants to merge 3 commits into
yangsf5 wants to merge 3 commits into
Conversation
Keep bin, lib, and scripts together across Agents, Codex, Factory, OpenCode, Cursor, and Kiro installs. Add Unix symlink and Windows copy regression coverage for commands that load runtime assets from scripts.
Co-Authored-By: OpenAI Codex <noreply@openai.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
yangsf5
marked this pull request as ready for review
August 24, 2026 13:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why (in your own words)
Slim installs put
bin/andlib/into each host runtime root but leave out the top-levelscripts/directory. Several shipped commands load runtime data and TypeScript modules from../scripts, so a normal install can makegstack-question-preference,gstack-developer-profile, andgstack-brain-cachefail even though the same commands work from a full source checkout. This keepsbin/,lib/, andscripts/together for every slim runtime root instead of maintaining a second, easy-to-drift manifest of six runtime files.I searched existing issues and pull requests before opening this. #2198 is the closest open PR, but it only adds
lib/to the OpenCode install path. #2305 covered an earlier missing-lib/failure, and #2454 / #2604 covered per-skill Claude runtime assets. None covers the missing top-levelscripts/dependency across Agents, Codex, Factory, OpenCode, Cursor, and Kiro runtime roots.Live evidence
The same temporary runtime root was exercised before and after adding
scripts/. These are the real command results from macOS arm64 with Bun 1.4.0:The focused install matrix runs the real setup shell blocks and the same commands through every affected runtime root:
Scope
scripts/besidebin/andlib/in Agents sidecars; Codex, Factory, OpenCode, Cursor, and Kiro runtime roots; and Cursor repository sidecars. Align declarative host defaults, OpenCode's override, host-authoring docs, and the Windows curated test list with that runtime contract.bash -n setup,git diff --check, and the public-repo redaction scan also pass (the scan reports version-number-only medium false positives and zero high findings).windows-latestlane. No paid model evals were run because this changes installer assets, not prompts. The full free suite on the updated branch has four failures in two files: threebrain-cache-roundtriptimeouts and one symlink-equivalentgstack-gbrain-syncfailure. A detached pristineorigin/mainworktree atad84005reproduces all four failure cases (and two additional brain-cache timeouts), while all tests in this change's scope pass.Liveness proof (required)
GSTACK PRtyped live into the author's terminal:Checklist
GSTACK PRtyped live into a real surface (not edited onto the image)Documentation
docs/ADDING_A_HOST.mdnow states that a slim runtime root must keepbin/,lib/, andscripts/together.CHANGELOG.mdrecords the user-visible failure mode, affected hosts, and regression coverage for v1.69.1.0.