fix(browse): reset profile crash markers so headed launch stops showing the profile-error bubble - #2672
Open
crsc1 wants to merge 1 commit into
Open
fix(browse): reset profile crash markers so headed launch stops showing the profile-error bubble#2672crsc1 wants to merge 1 commit into
crsc1 wants to merge 1 commit into
Conversation
…howing the profile-error bubble close() SIGKILLs Chromium when a graceful shutdown overruns closeRaceMs, so Default/Preferences is left with exit_type "Crashed". The next headed launch paints "Something went wrong when opening your profile" over the page, which lands in screenshots and swallows clicks near the top of the viewport. cleanSingletonLocks() already handles the half of this that blocks launch outright. This adds resetProfileExitState() next to it, sharing the same directory guard, and calls it from both persistent-context launch paths. --hide-crash-restore-bubble does not cover this: that flag suppresses the session-restore bubble, while the profile-error bubble reads the profile's own stored exit state, so it has to be reset on disk.
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Headed Chromium shows "Something went wrong when opening your profile. Some features may be unavailable." over the page on most launches. It lands in screenshots and swallows clicks near the top of the viewport, so
/browse --headedQA has to dismiss it first.Cause:
close()falls back toSIGKILLwhen a graceful shutdown overrunscloseRaceMs(browser-manager.ts), soDefault/Preferenceskeepsexit_type: "Crashed". Chromium reports the unclean profile on the next launch.cleanSingletonLocks()already handles the half of this that blocks launch outright. This addsresetProfileExitState()beside it in config.ts, sharing the same directory guard via an extractedresolveRecognizedProfileDir(), and calls it from bothlaunchPersistentContextpaths (launchHeadedand the handoff path).--hide-crash-restore-bubble(browser-manager.ts:547, :1711) does not cover this one. That flag suppresses the session-restore bubble; the profile-error bubble reads the profile's own stored exit state, so it has to be reset on disk. Confirmed by testing the flag against a Crashed profile.Notes:
$CHROMIUM_PROFILE, so gbrowser per-workspace profiles are covered.bun run scripts/test-free-shards.tsis green apart from 3 pre-existing brain-cache-roundtrip failures that import nothing in this diff.Related but not the same: #2311 (SingletonLock in handoff), #2492 (per-project headed profile). Should merge cleanly with either.