fix(brain-sync): fail loud when artifacts source has zero pages - #2670
Open
jzeisweiss wants to merge 1 commit into
Open
fix(brain-sync): fail loud when artifacts source has zero pages#2670jzeisweiss wants to merge 1 commit into
jzeisweiss wants to merge 1 commit into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
jzeisweiss
force-pushed
the
codex/bug/3047-brain-sync-indexing
branch
from
August 27, 2026 06:42
91c53e9 to
eb6654f
Compare
Author
|
Rebased onto current Local verification after rebase: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index_failedwhen that source reports zero pages; otherwise report the git result and explicitly mark index freshness as unverifiedThis deliberately does not run
gbrain syncat every skill boundary: that operation is expensive and owns a single-writer database. Missing, unavailable, invalid, or nonzero probe results remain truthfulindexing not verifiedoutcomes rather than false indexing claims.Refs jzeisweiss/my_dog_molly#3047.
Verification
Red first on upstream
main: the zero-page regression returned status 0 before this change. The final test proves a real artifact commit reaches the remote, then the command fails because the maintained source still has zero pages.bun test test/brain-sync.test.ts test/gstack-gbrain-sync.test.ts test/brain-sync-windows-paths.test.ts test/gbrain-spawn-windows-shell.test.ts— 122 pass, 0 failbash -n bin/gstack-brain-syncshellcheck --severity=error bin/gstack-brain-syncgit diff --checkThe broader free suite completed every shard except one unrelated timeout-wrapper timing assertion under six-way load (
rc=143vsrc=124); that assertion passes standalone on both this commit and pristine upstreammain.