pull\ - #2659
Open
disburyben wants to merge 8 commits into
Open
Conversation
Empty catches hid failures that leave the system degraded: a broken command audit trail, an unusable device salt, unwritable sidebar state files, an unreadable JSONL store reported as empty, and a path check that fell back to an unresolved path. Each site now either reports (warnOnce/stderr) or propagates, without turning best-effort work into a fatal error. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
- hosts/claude/hooks/hook-common.ts: AUQ hook stdin/logging/spawn plumbing - design/src/openai.ts: Responses + vision API transport - browse/src/session-cookie-registry.ts: SSE/PTY session cookie registry - browse/src/path-security.ts: snapshot output path validation - scripts/resolvers/codex-helpers.ts: single copy of skill frontmatter helpers Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: ben <ben@bendisbury.com>
- hosts/claude/hooks/hook-common.ts: AUQ hook stdin/logging/spawn plumbing - design/src/openai.ts: Responses + vision API transport - browse/src/session-cookie-registry.ts: SSE/PTY session cookie registry - browse/src/path-security.ts: snapshot output path validation - scripts/resolvers/codex-helpers.ts: single copy of skill frontmatter helpers Co-authored-by: ben <ben@bendisbury.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…unit-tests Co-authored-by: ben <ben@bendisbury.com>
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: ben <ben@bendisbury.com>
Stop swallowing errors in audit, device-salt, state-file, and JSONL-store paths
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why (in your own words)
Live evidence
Scope
Liveness proof (required)
Checklist
GSTACK PRtyped live into a real surface (not edited onto the image)