This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Normalisation and Signing of Component Descriptor #47
Merged
enrico-kaack-comp
merged 36 commits into
gardener-attic:master
from
enrico-kaack-comp:normAndSignature
Feb 28, 2022
Merged
Normalisation and Signing of Component Descriptor #47
enrico-kaack-comp
merged 36 commits into
gardener-attic:master
from
enrico-kaack-comp:normAndSignature
Feb 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
Needs review
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
needs/second-opinion
Needs second review by someone else
labels
Oct 20, 2021
schrodit
suggested changes
Oct 21, 2021
gardener-robot
added
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
and removed
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
labels
Oct 26, 2021
Open Questions:
|
schrodit
suggested changes
Nov 5, 2021
I think we should at least support
I'm no security expert so i will forward that question to @ThormaehlenFred |
@jschicktanz You have pull request review open invite, please check |
ccwienk
reviewed
Nov 9, 2021
ccwienk
reviewed
Nov 9, 2021
schrodit
reviewed
Nov 9, 2021
allows ommiting a digest by setting it nil
better types, disable html escaping
Sugestion: change Digest.Algorithm and Digest.Value to Digest.Digest = sha256:asd @mandelsoft |
DONE: write digest algorithm e.g. sha256 always lowercase |
Consider changing rsa test key generation. |
jschicktanz
approved these changes
Feb 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs/changes
Needs (more) changes
needs/review
Needs review
needs/second-opinion
Needs second review by someone else
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Introduces normalisation and signing.
Only implements Private Key based signing right now.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: