Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Normalisation and Signing of Component Descriptor #47

Merged

Conversation

enrico-kaack-comp
Copy link
Collaborator

@enrico-kaack-comp enrico-kaack-comp commented Oct 20, 2021

What this PR does / why we need it:
Introduces normalisation and signing.
Only implements Private Key based signing right now.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

  • To generate private and public key:
openssl genrsa -out private 4096
openssl rsa -in private -outform PEM -pubout -out public

Release note:


@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Oct 20, 2021
bindings-go/apis/v2/cdutils/normalize.go Outdated Show resolved Hide resolved
bindings-go/apis/v2/cdutils/normalize.go Outdated Show resolved Hide resolved
bindings-go/apis/v2/cdutils/normalize.go Outdated Show resolved Hide resolved
bindings-go/apis/v2/cdutils/normalize.go Outdated Show resolved Hide resolved
bindings-go/apis/v2/cdutils/normalize.go Outdated Show resolved Hide resolved
bindings-go/apis/v2/componentdescriptor.go Outdated Show resolved Hide resolved
bindings-go/apis/v2/componentdescriptor.go Outdated Show resolved Hide resolved
bindings-go/apis/v2/signatures/rsa.go Show resolved Hide resolved
bindings-go/apis/v2/signatures/types.go Outdated Show resolved Hide resolved
bindings-go/main/main.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Oct 21, 2021
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) and removed size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels Oct 26, 2021
@enrico-kaack-comp
Copy link
Collaborator Author

Open Questions:

  • support more Hash Algorithms other than sha256 (SHA512, SHA3_256, SHA3_512)?
  • Signing standard RSASSA-PKCS1-V1_5-SIGN suitable or should RSASSA-PSS be used?

bindings-go/apis/v2/componentdescriptor.go Outdated Show resolved Hide resolved
bindings-go/apis/v2/componentdescriptor.go Outdated Show resolved Hide resolved
bindings-go/apis/v2/componentdescriptor.go Outdated Show resolved Hide resolved
bindings-go/apis/v2/componentdescriptor.go Outdated Show resolved Hide resolved
bindings-go/apis/v2/componentdescriptor.go Outdated Show resolved Hide resolved
bindings-go/apis/v2/signatures/normalize.go Outdated Show resolved Hide resolved
bindings-go/apis/v2/signatures/rsa.go Show resolved Hide resolved
bindings-go/apis/v2/signatures/rsa.go Show resolved Hide resolved
bindings-go/apis/v2/signatures/rsa.go Show resolved Hide resolved
bindings-go/apis/v2/signatures/types.go Outdated Show resolved Hide resolved
@schrodit
Copy link

schrodit commented Nov 5, 2021

Open Questions:

  • support more Hash Algorithms other than sha256 (SHA512, SHA3_256, SHA3_512)?
  • Signing standard RSASSA-PKCS1-V1_5-SIGN suitable or should RSASSA-PSS be used?

I think we should at least support sha512. But on the otherhand everyone is free to use other algorithms as they can create their own Hasher struct.

Signing standard RSASSA-PKCS1-V1_5-SIGN suitable or should RSASSA-PSS be used?

I'm no security expert so i will forward that question to @ThormaehlenFred

@gardener-robot
Copy link
Contributor

@jschicktanz You have pull request review open invite, please check

@enrico-kaack-comp
Copy link
Collaborator Author

enrico-kaack-comp commented Feb 15, 2022

Sugestion: change Digest.Algorithm and Digest.Value to Digest.Digest = sha256:asd @mandelsoft
for consistency.
DONE: As discussed, leave it as two separat values.

@enrico-kaack-comp
Copy link
Collaborator Author

enrico-kaack-comp commented Feb 17, 2022

DONE: write digest algorithm e.g. sha256 always lowercase

@enrico-kaack-comp enrico-kaack-comp marked this pull request as ready for review February 25, 2022 09:09
@enrico-kaack-comp
Copy link
Collaborator Author

Consider changing rsa test key generation.
Otherwise, merge on monday.

@enrico-kaack-comp enrico-kaack-comp merged commit 7eb2343 into gardener-attic:master Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants