Posets #89
Posets #89
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 86.80% 86.82% +0.02%
==========================================
Files 52 52
Lines 11967 12055 +88
==========================================
+ Hits 10388 10467 +79
- Misses 1579 1588 +9
🚀 New features to boost your workflow:
|
gap/order.gi
Outdated
| [IsList, IsNumericalSemigroup], | ||
| function(l,S) | ||
| local I; | ||
| if not (IsNumericalSemigroup(S)) then |
There was a problem hiding this comment.
This will always be false, since S must satisfy IsNumericalSemigroup in order for this method to be applied. I think you probably meant to check that l is not empty here, at least that's what the error message indicates.
There was a problem hiding this comment.
Yes, thanks! It was a function, and then was turned into an operation. I will change it.
There was a problem hiding this comment.
Actually, while transforming it on an operation, I did remove the wrong check! I wanted to check if the list is a list of integers ... Thanks to your comment I realized the mistake.
| [IsNumericalSemigroup, IsList], | ||
| function(S,l) | ||
| return PosetNS(l,S); | ||
| end); |
There was a problem hiding this comment.
| [IsNumericalSemigroup, IsList], | |
| function(S,l) | |
| return PosetNS(l,S); | |
| end); | |
| [IsNumericalSemigroup, IsList], PosetNS); |
Equivalent, but shorter.
There was a problem hiding this comment.
Really? I think I am changing here the order of the arguments ...
We want to call PosetNS(list, semigroup) and also PosetNS(semigroup, list)
There was a problem hiding this comment.
Ah yes you're right, sorry didn't notice that: could be {S, l} -> PosetNS(l, S) instead :)
james-d-mitchell
left a comment
james-d-mitchell
left a comment
There was a problem hiding this comment.
I know no-one asked, I noticed these things when somehow looking at this PR, and thought I'd comment, feel free to ignore me if my comments are unwelcome.
Co-authored-by: James Mitchell <james-d-mitchell@users.noreply.github.com>
Thanks! |
|
May be we could implement connected components ... |
2 participants
New category PosetNS
MaximalElements, MinimalElements, DownSet, UpSet, Antichain