Fix overflow in quicktime calibration loop #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/viztracer/modules/quicktime.c
Outdated
| t0_ts /= CALIBRATE_SIZE; | ||
| t0_ns /= CALIBRATE_SIZE; | ||
| // Do the expensive average calculation outside the measurement loop | ||
| int64_t ts_remainder = 0, ns_remainder = 0; |
There was a problem hiding this comment.
Looks good. Could you split this into two declarations? I'm always trying to avoid declaration like this - it's often okay for a few non-pointer variables, but it gets ugly when it's a pointer or the variable name is too long or there are too many of them. Just as a habit.
There was a problem hiding this comment.
Sure! Pushed it now
Technohacker
force-pushed
the
overflow-fix
branch
from
1c6ef5e to
64b3871
Compare
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #529