Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building on FreeBSD #432

Merged
merged 1 commit into from
May 9, 2024

Conversation

zebrapurring
Copy link
Contributor

@zebrapurring zebrapurring commented May 9, 2024

This PR adds support for building the package on FreeBSD through PTHREAD_NP, since it is not compatible with the gettid syscall.

Tested on FreeBSD 13.

@zebrapurring zebrapurring changed the title Add support for FreeBSD Add support for building on FreeBSD May 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c405d15) to head (78b7f20).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #432   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         2308      2308           
=========================================
  Hits          2308      2308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaogaotiantian
Copy link
Owner

Thanks. We don't have official support for FreeBSD because there's no github action runner for it. However, the patch is easy to follow and does not affect the platforms we do support. I'll merge it for people who use FreeBSD :)

@gaogaotiantian gaogaotiantian merged commit 9d8c956 into gaogaotiantian:master May 9, 2024
46 checks passed
@zebrapurring
Copy link
Contributor Author

Thanks! Some features like attaching to processes are still not working on FreeBSD, but at least this should allow installing the package via Pip and generating traces.

@gaogaotiantian
Copy link
Owner

Attaching would be hard. That is some nasty hack feature anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants