Fixed client id not being client id, used references instead of owned strings and added static cache for apple keys #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed sub to aud
extrawurst
reviewed
Jun 15, 2022
| @@ -23,8 +23,23 @@ use jsonwebtoken::{ | |||
| }; | |||
| use serde::de::DeserializeOwned; | |||
| use std::collections::HashMap; | |||
| use lazy_static::lazy_static; | |||
There was a problem hiding this comment.
this is a totally unrelated change to the mix up of aud. lets split this off into a separate PR, I would like to argue about the API of this there then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
audagainst client_id (app bundle id)Stringwith&strbecause why clone things around like a mad man ?Notes:
3 tests are broken because Apple changed keys kid.