Merge pull request #133 from game-node-app/dev

Greatly improves trending/games performance

src/statistics/dto/find-statistics-trending-games.dto.ts

@@ -4,12 +4,22 @@ import { GameRepositoryFilterDto } from "../../game/game-repository/dto/game-rep
 import { IsEnum, IsNotEmpty, IsOptional } from "class-validator";
 import { StatisticsPeriod } from "../statistics.constants";
 import { OmitType } from "@nestjs/swagger";
+import { Transform } from "class-transformer";
 
 export class FindStatisticsTrendingGamesDto extends OmitType(
     BaseFindDto<Statistics>,
     ["orderBy", "search"],
 ) {
     @IsOptional()
+    @Transform(({ value }) => {
+        const parsedCriteria: GameRepositoryFilterDto = {
+            ...value,
+            limit: undefined,
+            offset: undefined,
+        };
+
+        return parsedCriteria;
+    })
     criteria?: GameRepositoryFilterDto;
     @IsNotEmpty()
     @IsEnum(StatisticsPeriod)

src/statistics/game-statistics.service.ts

@@ -23,6 +23,7 @@ import { hours } from "@nestjs/throttler";
 import { GameRepositoryService } from "../game/game-repository/game-repository.service";
 import { GameFilterService } from "../game/game-filter/game-filter.service";
 import { MATURE_THEME_ID } from "../game/game-filter/game-filter.constants";
+import isEmptyObject from "../utils/isEmptyObject";
 
 @Injectable()
 export class GameStatisticsService implements StatisticsService {
@@ -176,7 +177,7 @@ export class GameStatisticsService implements StatisticsService {
             .where(`(uv.createdAt >= :uvDate OR s.viewsCount = 0)`, {
                 uvDate: viewsStartDate,
             })
-            // Excludes games with specific themes
+            // Excludes games with mature theme
             .andWhere(
                 `NOT EXISTS (SELECT 1 FROM game_themes_game_theme AS gtgt WHERE gtgt.gameId = s.gameId 
                 AND gtgt.gameThemeId = :excludedThemeId)`,
@@ -191,6 +192,15 @@ export class GameStatisticsService implements StatisticsService {
 
         const statistics = await query.getMany();
 
+        // This greatly improves performance when no filtering is actually being done.
+        if (criteria == undefined || isEmptyObject(criteria)) {
+            const slicedStatistics = statistics.slice(
+                offsetToUse,
+                offsetToUse + limitToUse,
+            );
+            return [slicedStatistics, fixedStatisticsLimit];
+        }
+
         const gameIds = statistics.map((s) => s.gameId);
         const games = await this.gameRepositoryService.findAllIdsWithFilters({
             ...criteria,

src/utils/isEmptyObject.ts

@@ -1,3 +1,14 @@
+/**
+ * Checks if a given object is empty ({})
+ * Note: this returns FALSE if 'obj' is null.
+ * @param obj
+ * @example
+ * const obj1 = {}
+ * isEmptyObject(obj1) // true
+ *
+ * const obj2 = null
+ * isEmptyObject(obj2) // false
+ */
 export default function isEmptyObject(obj: any) {
-    return JSON.stringify(obj) === JSON.stringify({});
+    return JSON.stringify(obj) === "{}";
 }