Fix (Dynamic Content): prevent blurry images when using image optimizer #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
bfintal
requested changes
Nov 20, 2024
|
|
||
| if ( ! function_exists( 'stackable_load_image_optimizer_polyfill_frontend_script' ) ) { | ||
| function stackable_load_image_optimizer_polyfill_frontend_script( $block_content, $block ) { | ||
| if ( ! is_admin() ) { |
There was a problem hiding this comment.
Let's only do this only when the EWWWW plugin is present
| } | ||
|
|
||
| if ( ! function_exists( 'stackable_load_image_optimizer_polyfill_frontend_script' ) ) { | ||
| function stackable_load_image_optimizer_polyfill_frontend_script( $block_content, $block ) { |
There was a problem hiding this comment.
Please add some comments here to explain why we need to load this file when EWWWW is present
| */ | ||
| import domReady from '@wordpress/dom-ready' | ||
|
|
||
| class ImageOptimizerPolyfill { |
There was a problem hiding this comment.
Please add a description of what this file is for, what it does, why we need it, and when it is loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3296