Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (icon label): return false for isEligible if there is no icon block #3368

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

mxkae
Copy link
Contributor

@mxkae mxkae commented Nov 14, 2024

if icon label is modified and does not have icon block, isEligible returns an error.

This fix checks if the icon label's inner block contains icon block.

if icon label is modified and does not have icon block, isEligible returns an error
@mxkae mxkae self-assigned this Nov 14, 2024
Copy link

🤖 Pull request artifacts

file commit
pr3368-stackable-3368-merge.zip 2c00470

github-actions bot added a commit that referenced this pull request Nov 14, 2024
@bfintal bfintal merged commit 92f2579 into develop Nov 14, 2024
1 of 6 checks passed
@bfintal bfintal deleted the fix/icon-label-add-checking-for-is-eligible branch November 14, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants