FIX check if shapes exist before setting the labels in the WebGL viewer #501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm having some issues with loading some very old overlay files. Without the fix in the javascript part, the viewer does not even load. The fix in
svgoverlay.py
is still a work in progress. It fails creating splines for paths such as the followingI think
gen_path
inpycortex/cortex/svgoverlay.py
Lines 907 to 916 in 2a9a5bc
C
mode.