Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uniprot downloader: streaming requests etc #615

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bernt-matthias
Copy link
Collaborator

@bernt-matthias bernt-matthias commented Jul 6, 2021

  • use streaming requests and huge timeout (3600s) for allowing to download huge datasets (tested for 2.4GB which timed out before)
  • add tabular output and column selector
  • use reviewed filter for all input types not only for input_choice == common

For discussion:

  • switch to standard select for the column selector?
    • I like the hierarchy, but select has the advantage to be searchable
    • linting fails due to incomplete xsd, I think...
  • implement more advanced queries https://www.uniprot.org/help/query-fields?

- use streaming requests and huge timeout (3600s) for allowing to download huge datasets (tested for 2.4GB which timed out before)
- add tabular output and column selector
- use reviewed filter for all input types not only for `input_choice == common`
and fix linter errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant