Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ProteoRE ID_converter tool #602

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

combesf
Copy link
Collaborator

@combesf combesf commented Jun 1, 2021

Proteore id_converter tool
version 20210601
for review, thank you

@combesf combesf changed the title [WIP] id converter proteore tool id converter proteore tool Jun 1, 2021
@yvandenb yvandenb assigned yvandenb and vloux and unassigned yvandenb Jun 1, 2021
@yvandenb yvandenb changed the title id converter proteore tool [WIP] id converter proteore tool Jun 2, 2021
@yvandenb yvandenb changed the title [WIP] id converter proteore tool [WIP] ProteoRE ID_converter tool Jun 2, 2021
@combesf
Copy link
Collaborator Author

combesf commented Jun 3, 2021

I still have an error in the tool test here.
The error is :
parameter 'mapping_file': requires a value, but no legal values defined

But in the xml file, in the test lines, mapping_file is affected, so I don't understand ...

If someone could help here please ???
thansk a lot
@bgruening @vloux

</param>
<when value="Human">
<param name="mapping_file" type="select" label="Release" >
<options from_data_table="proteore_id_mapping_Human">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should stick to small letters for variable names

<param name="ncol" value="c1"/>
</conditional>
<conditional name="species">
<param name="mapping_file" value='human_id_mapping_file.tsv'/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this here needs to be a value from your loc file.

https://github.com/galaxyproteomics/tools-galaxyp/pull/602/files#diff-1fcdfc7eef4418ad2c2fb5d674d84ecc7d287a211349e35843d9a6e5a1d6fcbe

So in this case the value= should be human_id_mapping

tools/proteore_id_converter/id_converter.xml Outdated Show resolved Hide resolved
@bgruening
Copy link
Member

@combesf can you have a look at this tool: https://github.com/bgruening/galaxytools/tree/master/tools/general_mapping

Its more generic I think and maybe you can use that tool instead?

@yvandenb
Copy link

yvandenb commented Jun 4, 2021

can you have a look at this tool: https://github.com/bgruening/galaxytools/tree/master/tools/general_mapping
@bgruening : not sure that these tools are exactly the same; btw I was unable to find it in the TS so that we can install it on our dev-instance for evaluation purpose, could provide us with the exact name or a link ? is this tool deployed in usegalaxy.eu ?

@foellmelanie
Copy link
Contributor

Hi @yvandenb I am not sure where the general mapping tool is but I think the 'uniprot_rest_interface' Uniprot tool can do the ID conversions for many different IDs and organisms: https://toolshed.g2.bx.psu.edu/repository?repository_id=c8774310981b07c5 It's also installed on the EU server.

@bgruening
Copy link
Member

@combesf, @yvandenb I never published the tool in the toolshed, but at this time I wanted to solve the exact same problem as you, but in a more general way: https://github.com/bgruening/galaxytools/blob/master/tools/general_mapping/readme.md

In essence, an admin can create config files, of arbitrary mapping files. One tool that can map IDs for proteomics and physics and so on...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants