Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProteoRE tool 'get_unique_peptide_srm_method' #591

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

combesf
Copy link
Collaborator

@combesf combesf commented May 10, 2021

Another ProteoRE tool ; this one is 'get_unique_peptide_srm_method'

Thanks for the review !

Still 16 tools to come ...

@yvandenb yvandenb changed the title [WIP] Adding ProteoRE tool 'get_unique_peptide_srm_method' Version 2021.04.20 [WIP] ProteoRE tool 'get_unique_peptide_srm_method' Version 2021.04.20 Jun 2, 2021
@combesf combesf changed the title [WIP] ProteoRE tool 'get_unique_peptide_srm_method' Version 2021.04.20 ProteoRE tool 'get_unique_peptide_srm_method' Jun 3, 2021
@combesf
Copy link
Collaborator Author

combesf commented Jun 14, 2021

@bgruening we are all set on our side for this PR.
If you could please review it ... Thank you very much for all the help !

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Human_SRM_atlas_2016-04.csv is super big. Does it really need to be shipped with the tool, or should the admin download it on demand? Will this file change over time? Can we compress it?

--features='$protein_features'
--output='$output'

#if "SRM_atlas" in str($srm_file).split("/")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could do a string search with if "/SRM_atlas/" in $srm_file I guess

<tests>
<test>
<conditional name="input" >
<param name="ids" value="file"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a second test for the text input?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping

@vloux
Copy link
Contributor

vloux commented Jun 16, 2021

Human_SRM_atlas_2016-04.csv is super big. Does it really need to be shipped with the tool, or should the admin download it on demand? Will this file change over time? Can we compress it?

Thanks Björn, this file does not change over time. I gziped it and lade modifications in the wrapper (loc file) and Python script to take gzip csv file as input.

<param name="header" value="true" />
<param name="ncol" value="c1"/>
</conditional>
<param name="srm_file" value="tool-data/Human_SRM_atlas_2016-04.csv.gz" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wired. I would assume the value needs to be the key/id from the datatable. E.g. 9979839599?

</conditional>
<param name="srm_file" type="select" label="Release" >
<options from_data_table="proteore_human_srm_atlas">
<filter type="sort_by" column="0"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we realy want to sort for the ID column? E.g. 9979839599 ... what is this number? Should we sort for column 1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants