Adopt @galaxyproject/galaxy-ops for the invocation read (proof of the shared agent core)#202
Draft
dannon wants to merge 1 commit into
Draft
Adopt @galaxyproject/galaxy-ops for the invocation read (proof of the shared agent core)#202dannon wants to merge 1 commit into
dannon wants to merge 1 commit into
Conversation
…typed Galaxy invocation interfaces Replaces the hand-rolled galaxyGet<GalaxyInvocationResponse>() call in checkInvocations with getInvocationDetails from @galaxyproject/galaxy-ops, and deletes the three hand-typed interfaces (GalaxyInvocationResponse, GalaxyInvocationStep, GalaxyInvocationStepJob) that are now covered by the upstream schema types. Test mock updated to vi.mock the ops package instead of spying on the internal galaxyGet.
dannon
force-pushed
the
galaxy-ops-adoption-pr
branch
from
d4a6faf to
7e5a9aa
Compare
This was referenced Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof that the shared agent-operations core (galaxy-ops, galaxyproject/galaxy-mcp#61) actually removes duplication in Loom rather than adding a layer.
Swaps Loom's hand-rolled invocation read for the
getInvocationsop from@galaxyproject/galaxy-ops:extensions/loom/galaxy-api.tsplus three hand-typed invocation interfaces that re-declared shapes already in Galaxy's OpenAPI schemajob.statecomparisons go from uncheckedstringto compiler-verifiedJobStatetests/invocation-check.test.ts)Not mergeable as-is: it pulls galaxy-ops from a local tarball (
file:.../galaxy-ops.tgz) because the package isn't published yet, so it stays a draft until galaxy-ops has a real home + npm publish (the open question on #61). The point now is to show the deletion is real and the types line up.