Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CI #2498

Closed
Closed

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

singlecoder and others added 30 commits June 14, 2024 22:46
* refactor: opt code

* refactor: opt code

* fix: batch bug

* refactor: opt code

* refactor: opt code

* refactor: opt code

* refactor: opt code

* refactor: opt code

* refactor: opt code

* fix: unit test

* refactor: opt code

* refactor: fix lint

* refactor: opt code

* refactor: opt code

* refactor: opt code

* refactor: opt code

* refactor: opt code

* refactor: opt code

* refactor: opt code

* refactor: opt code

* refactor: opt code

* refactor: opt code

* refactor: opt code

* refactor: opt code

* refactor: remove RenderElement

* refactor: rename RenderData to RenderElement

* refactor: opt code

* refactor: opt code

* refactor: opt code
* feat: ui transform
cptbtptpbcptdtptp and others added 24 commits January 8, 2025 16:07
* refactor: `PostProcessParameter` to strong type
* feat: support callback props in parser
* refactor: remove unused physx function

* feat: update downgrade version
* refactor:  update physX wasm without assertions
Fix: Merge code and fix unit test error
refactor: UIRenderer.raycastEnable -> UIRenderer.raycastEnabled
Copy link

coderabbitai bot commented Jan 9, 2025

Warning

Rate limit exceeded

@cptbtptpbcptdtptp has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 32 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 63a5662 and 0cfaad2.

⛔ Files ignored due to path filters (11)
  • packages/physics-physx/libs/physx.release.wasm is excluded by !**/*.wasm
  • packages/ui/src/shader/uiDefault.fs.glsl is excluded by !**/*.glsl
  • packages/ui/src/shader/uiDefault.vs.glsl is excluded by !**/*.glsl
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • tests/src/core/2d/text/__screenshots__/TextRenderer.test.ts/TextRenderer-bounds-1.png is excluded by !**/*.png
  • tests/src/core/__screenshots__/Sprite.test.ts/Sprite-get-set-size-1.png is excluded by !**/*.png
  • tests/src/core/__screenshots__/SpriteMask.test.ts/SpriteMask--render-1.png is excluded by !**/*.png
  • tests/src/core/__screenshots__/SpriteMask.test.ts/SpriteMask-get-set-size-1.png is excluded by !**/*.png
  • tests/src/core/__screenshots__/SpriteRenderer.test.ts/SpriteRenderer--render-1.png is excluded by !**/*.png
  • tests/src/core/__screenshots__/SpriteRenderer.test.ts/SpriteRenderer-get-set-size-1.png is excluded by !**/*.png
  • tests/src/core/audio/__screenshots__/AudioSource.test.ts/AudioSource-load-1.png is excluded by !**/*.png
📒 Files selected for processing (82)
  • packages/core/src/2d/assembler/ISpriteAssembler.ts (1 hunks)
  • packages/core/src/2d/assembler/ISpriteRenderer.ts (1 hunks)
  • packages/core/src/2d/assembler/SimpleSpriteAssembler.ts (4 hunks)
  • packages/core/src/2d/assembler/SlicedSpriteAssembler.ts (5 hunks)
  • packages/core/src/2d/assembler/TiledSpriteAssembler.ts (7 hunks)
  • packages/core/src/2d/enums/SpriteModifyFlags.ts (1 hunks)
  • packages/core/src/2d/index.ts (1 hunks)
  • packages/core/src/2d/sprite/Sprite.ts (6 hunks)
  • packages/core/src/2d/sprite/SpriteMask.ts (5 hunks)
  • packages/core/src/2d/sprite/SpriteRenderer.ts (13 hunks)
  • packages/core/src/2d/sprite/index.ts (1 hunks)
  • packages/core/src/2d/text/ITextRenderer.ts (1 hunks)
  • packages/core/src/2d/text/TextRenderer.ts (3 hunks)
  • packages/core/src/2d/text/TextUtils.ts (11 hunks)
  • packages/core/src/2d/text/index.ts (1 hunks)
  • packages/core/src/Camera.ts (12 hunks)
  • packages/core/src/ComponentsManager.ts (4 hunks)
  • packages/core/src/Engine.ts (4 hunks)
  • packages/core/src/Entity.ts (10 hunks)
  • packages/core/src/RenderPipeline/BasicRenderPipeline.ts (1 hunks)
  • packages/core/src/RenderPipeline/BatcherManager.ts (2 hunks)
  • packages/core/src/RenderPipeline/RenderQueue.ts (1 hunks)
  • packages/core/src/RenderPipeline/index.ts (1 hunks)
  • packages/core/src/Renderer.ts (4 hunks)
  • packages/core/src/Scene.ts (1 hunks)
  • packages/core/src/Script.ts (5 hunks)
  • packages/core/src/Transform.ts (0 hunks)
  • packages/core/src/enums/CameraModifyFlags.ts (1 hunks)
  • packages/core/src/enums/EntityModifyFlags.ts (1 hunks)
  • packages/core/src/index.ts (2 hunks)
  • packages/core/src/input/index.ts (1 hunks)
  • packages/core/src/input/pointer/Pointer.ts (2 hunks)
  • packages/core/src/input/pointer/PointerEventData.ts (1 hunks)
  • packages/core/src/input/pointer/PointerManager.ts (7 hunks)
  • packages/core/src/input/pointer/emitter/IHitResult.ts (1 hunks)
  • packages/core/src/input/pointer/emitter/PhysicsPointerEventEmitter.ts (1 hunks)
  • packages/core/src/input/pointer/emitter/PointerEventEmitter.ts (1 hunks)
  • packages/core/src/mesh/MeshRenderer.ts (2 hunks)
  • packages/core/src/particle/ParticleRenderer.ts (1 hunks)
  • packages/core/src/physics/HitResult.ts (1 hunks)
  • packages/core/src/physics/PhysicsScene.ts (1 hunks)
  • packages/core/src/physics/joint/Joint.ts (2 hunks)
  • packages/core/src/shader/index.ts (1 hunks)
  • packages/core/src/ui/IUICanvas.ts (1 hunks)
  • packages/core/src/ui/UIUtils.ts (1 hunks)
  • packages/design/src/index.ts (1 hunks)
  • packages/loader/src/SpriteAtlasLoader.ts (1 hunks)
  • packages/loader/src/SpriteLoader.ts (1 hunks)
  • packages/math/src/BoundingBox.ts (2 hunks)
  • packages/ui/README.md (1 hunks)
  • packages/ui/package.json (1 hunks)
  • packages/ui/src/Utils.ts (1 hunks)
  • packages/ui/src/component/UICanvas.ts (1 hunks)
  • packages/ui/src/component/UIGroup.ts (1 hunks)
  • packages/ui/src/component/UIRenderer.ts (1 hunks)
  • packages/ui/src/component/UITransform.ts (1 hunks)
  • packages/ui/src/component/advanced/Button.ts (1 hunks)
  • packages/ui/src/component/advanced/Image.ts (1 hunks)
  • packages/ui/src/component/advanced/Text.ts (1 hunks)
  • packages/ui/src/component/interactive/UIInteractive.ts (1 hunks)
  • packages/ui/src/component/interactive/transition/ColorTransition.ts (1 hunks)
  • packages/ui/src/component/interactive/transition/ScaleTransition.ts (1 hunks)
  • packages/ui/src/component/interactive/transition/SpriteTransition.ts (1 hunks)
  • packages/ui/src/component/interactive/transition/Transition.ts (1 hunks)
  • packages/ui/src/enums/CanvasRenderMode.ts (1 hunks)
  • packages/ui/src/enums/ResolutionAdaptationMode.ts (1 hunks)
  • packages/ui/src/index.ts (1 hunks)
  • packages/ui/src/input/UIHitResult.ts (1 hunks)
  • packages/ui/src/input/UIPointerEventEmitter.ts (1 hunks)
  • packages/ui/src/interface/IElement.ts (1 hunks)
  • packages/ui/src/interface/IGraphics.ts (1 hunks)
  • packages/ui/src/interface/IGroupAble.ts (1 hunks)
  • packages/ui/src/shader/global.d.ts (1 hunks)
  • packages/ui/tsconfig.json (1 hunks)
  • tests/package.json (1 hunks)
  • tests/src/core/2d/text/TextUtils.test.ts (5 hunks)
  • tests/src/core/Sprite.test.ts (0 hunks)
  • tests/src/core/SpriteMask.test.ts (4 hunks)
  • tests/src/core/SpriteRenderer.test.ts (25 hunks)
  • tests/src/ui/Image.test.ts (1 hunks)
  • tests/src/ui/Text.test.ts (1 hunks)
  • tests/src/ui/UICanvas.test.ts (1 hunks)

Finishing Touches

  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 70.90345% with 1314 lines in your changes missing coverage. Please review.

Project coverage is 68.48%. Comparing base (ec6ca8c) to head (0cfaad2).
Report is 1 commits behind head on dev/1.4.

Files with missing lines Patch % Lines
packages/ui/src/component/advanced/Text.ts 38.42% 399 Missing ⚠️
packages/ui/src/input/UIPointerEventEmitter.ts 22.68% 167 Missing ⚠️
packages/ui/src/component/UICanvas.ts 75.74% 154 Missing ⚠️
packages/ui/src/component/advanced/Image.ts 55.55% 140 Missing ⚠️
packages/ui/src/component/UIRenderer.ts 64.88% 105 Missing ⚠️
...src/component/interactive/transition/Transition.ts 62.56% 70 Missing ⚠️
...ages/ui/src/component/interactive/UIInteractive.ts 87.45% 34 Missing ⚠️
packages/core/src/input/pointer/PointerManager.ts 64.51% 33 Missing ⚠️
...mponent/interactive/transition/SpriteTransition.ts 38.77% 30 Missing ⚠️
...e/src/input/pointer/emitter/PointerEventEmitter.ts 82.91% 27 Missing ⚠️
... and 22 more
Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.4    #2498      +/-   ##
===========================================
- Coverage    68.96%   68.48%   -0.48%     
===========================================
  Files          925      956      +31     
  Lines        96176   100007    +3831     
  Branches      8168     8545     +377     
===========================================
+ Hits         66326    68490    +2164     
- Misses       29595    31261    +1666     
- Partials       255      256       +1     
Flag Coverage Δ
unittests 68.48% <70.90%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cptbtptpbcptdtptp cptbtptpbcptdtptp deleted the feature/ui-init branch January 9, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants